Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs add missing config keys #1270

Merged
merged 5 commits into from
Jan 13, 2024
Merged

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Jan 12, 2024

Adds several supported, but missing keys to the docs. Updates some language to be more consistent.

#1268

@mlw mlw added the docs Documentation-related issues label Jan 12, 2024
@mlw mlw added this to the 2024.1 milestone Jan 12, 2024
@mlw mlw requested a review from a team as a code owner January 12, 2024 21:24
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just remove the typo.

docs/deployment/configuration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw merged commit f93e1a5 into google:main Jan 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants